vsphere_guest: vm_nic should include manual MAC change feature

[sruslanas]

ISSUE TYPE

Bug Report

COMPONENT NAME

vsphere_guest

ANSIBLE VERSION

N/A

SUMMARY

Currently during VM reconfiguring following options are supported for vm_nic.

vm_nic:
      nic1:
        type: vmxnet3
        network: VM Network
        network_type: standard

I think this should be extended with feature to define MAC address manually, adding
address_type: manual
address: "00:0c:29:ac:70:96"

Final look might be like:

vm_nic:
      nic1:
        type: vmxnet3
        network: VM Network
        network_type: standard
        address_type: manual
        address: "00:0c:29:ac:70:96" 

This functionality looks like might be supported by pysphere, but currently not implemented in Ansible.

This feature might be useful when Ansible is used to rebuild same VMs multiple times and there are static DHCP leases configured for exact MAC addresses.

[sruslanas]

net_device is correct vm.properties.config.hardware.device

#Set Nic macAddress to Manual and set address
net_device.set_element_addressType("Manual")
net_device.set_element_macAddress(new_mac)

Currently I am using workaround python script, which can do the same, if you need full script let me know.

[ansibot]

@chrrrles, @rhoop, ping. This issue is still waiting on your response.
click here for bot help

[rhoop]

This sounds like a feature request. Do you have a working version you can submit for PR?

[ansibot]

@chrrrles, @rhoop, ping. This issue is still waiting on your response.
click here for bot help

[sruslanas]

@rhoop Someone picked up and implemented the idea here #3643

[ansibot]

@chrrrles, @rhoop, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@chrrrles, @rhoop, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

[ansibot]

This issue was migrated to ansible/ansible#29803