Avoid import errors from filters when running in nodeps mode (#4651)

Author: ssbarnea

examples/playbooks/filter_plugins/filter_with_importerror.py

@@ -0,0 +1,32 @@
+"""Sample filter that should raise an ImportError when used."""
+
+from collections.abc import Callable
+from typing import Any
+
+# pylint: skip-file
+
+DOCUMENTATION = """
+name: from_yaml
+description:
+    - This callback just adds total play duration to the play stats.
+"""
+
+
+def filter_with_importerror(data: Any) -> dict[str, str]:  # noqa: ARG001
+    """Sample filter.
+
+    :return: dict
+    """
+    import a_module_that_does_not_exist  # type: ignore[reportMissingImports] # noqa: F401
+
+    return {}
+
+
+class FilterModule:
+    """Core filter plugins."""
+
+    def filters(self) -> dict[str, Callable[..., dict[str, str]]]:
+        """Return implemented filters."""
+        return {
+            "filter_with_importerror": filter_with_importerror,
+        }

examples/playbooks/test_filter_with_importerror.yml

@@ -0,0 +1,7 @@
+---
+- name: Fixture
+  hosts: localhost
+  tasks:
+    - name: Test
+      ansible.builtin.debug:
+        msg: "Some {{ 'foo' | filter_with_importerror }}"

src/ansiblelint/rules/jinja.py

@@ -14,7 +14,9 @@
 import black
 import jinja2
 from ansible.errors import AnsibleError, AnsibleFilterError, AnsibleParserError
+from ansible_compat.config import ansible_version
 from jinja2.exceptions import TemplateSyntaxError
+from packaging.version import Version
 
 from ansiblelint.errors import RuleMatchTransformMeta
 from ansiblelint.file_utils import Lintable
@@ -145,11 +147,15 @@ def matchtask(
                     except AnsibleFilterError:
                         bypass = True
                     # ValueError RepresenterError
-                    except AnsibleError as exc:
+                    except (AnsibleError, ImportError) as exc:
                         bypass = False
-                        orig_exc = (
-                            exc.orig_exc if getattr(exc, "orig_exc", None) else exc
-                        )
+                        orig_exc = exc
+                        if (
+                            isinstance(exc, AnsibleError)
+                            and hasattr(exc, "orig_exc")
+                            and exc.orig_exc
+                        ):
+                            orig_exc = exc.orig_exc
                         orig_exc_message = getattr(orig_exc, "message", str(orig_exc))
                         match = self._ansible_error_re.match(
                             getattr(orig_exc, "message", str(orig_exc)),
@@ -185,6 +191,12 @@ def matchtask(
                                 bypass = True
                             else:
                                 bypass = False
+                        elif isinstance(exc, ImportError):
+                            if self.options and self.options.nodeps:
+                                msg = f"Ignored exception {exc} due to running with nodeps mode."
+                                _logger.debug(msg)
+                                continue
+                            bypass = False
                         elif re.match(r"^lookup plugin (.*) not found$", exc.message):
                             # lookup plugin 'template' not found
                             bypass = True
@@ -905,3 +917,25 @@ def _do_template(*args, **kwargs):  # type: ignore[no-untyped-def] # Templar.do_
         with mock.patch.object(Templar, "do_template", _do_template):
             results = Runner(lintable, rules=collection).run()
             assert len(results) == 0
+
+    @pytest.mark.parametrize(
+        ("nodeps", "expected_results"),
+        (
+            pytest.param(
+                "0",
+                0 if ansible_version() >= Version("2.19.0.dev0") else 1,
+                id="normal",
+            ),
+            pytest.param("1", 0, id="nodeps"),
+        ),
+    )
+    def test_filter_import_failure(
+        nodeps: str, expected_results: int, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        """Tests how we process import failures from within filters."""
+        monkeypatch.setenv("ANSIBLE_LINT_NODEPS", nodeps)
+        collection = RulesCollection()
+        collection.register(JinjaRule())
+        lintable = Lintable("examples/playbooks/test_filter_with_importerror.yml")
+        results = Runner(lintable, rules=collection).run()
+        assert len(results) == expected_results

src/ansiblelint/utils.py

@@ -320,7 +320,7 @@ def template(
         )
         # Hack to skip the following exception when using to_json filter on a variable. # noqa: FIX004
         # I guess the filter doesn't like empty vars...
-    except (AnsibleError, ValueError, RepresenterError):
+    except (AnsibleError, ValueError, RepresenterError, ImportError):
         # templating failed, so just keep value as is.
         if fail_on_error:
             raise