Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies not installed from test-requirements.txt #258

Open
dbrennand opened this issue Oct 13, 2024 · 2 comments
Open

Dependencies not installed from test-requirements.txt #258

dbrennand opened this issue Oct 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dbrennand
Copy link

dbrennand commented Oct 13, 2024

Hi there,

I'm testing out ansible-dev-environment and I've noticed that with 24.9.0, it doesn't automatically install the dependencies I have listed in a test-requirements.txt file in my collection directory: https://github.com/dbrennand/molecule-test/blob/testing-more/ansible/test-requirements.txt

Repro steps:

pip install ansible-dev-environment==24.9.0 --user
git clone [email protected]:dbrennand/molecule-test.git
cd molecule-test/
git checkout testing-more
pip list | grep ansible-dev-environment
ansible-dev-environment   24.9.0
ade install -e --venv venv -adt ./ansible
source venv/bin/activate
pip list | grep hvac
# hvac is not installed :-(

From the usage example it seems to be possible to install from this file:

INFO: Installing python requirements from /home/bthornto/github/network.interfaces/test-requirements.txt
@ssbarnea
Copy link
Member

That should not be too hard to implement but I am bit worried about some side effects:

  • are there any users that might not want to install test dependencies?
  • should this be hidden under a flag? If so, that flag should be enabled by default or disabled?
  • what about recursivity? should this also apply to other collections?
  • what should be the standard filename for them test-requirements.txt or requirements-test.txt
  • if we consider using pyproject.toml to retrieve them from an extra, implementation could become messy

@dbrennand
Copy link
Author

dbrennand commented Jan 4, 2025

Hi @ssbarnea - Thanks for your response. All good questions. Do you think we should take this conversation to https://forum.ansible.com to discuss with the wider community?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants