Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting #79

Closed
wants to merge 200 commits into from
Closed

Linting #79

wants to merge 200 commits into from

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:

  • new workflow
  • linting
  • readme updates
  • wifi control update
  • import_tasks - set file

How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A

frederickw082922
frederickw082922 approved these changes Sep 20, 2023
View reviewed changes
Copy link

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

georgenalen and others added 28 commits September 20, 2023 17:05
@georgenalen @uk-bolly
adjusted devel to main action
76648dd 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
added gitignore
cb5bbc5 
Signed-off-by: George Nalen <[email protected]>
@cawamata @uk-bolly
Update ubtu18cis_4_1_5_systemlocale.rules.j2
6381471 
Signed-off-by: Kawamata <[email protected]>
@cawamata @uk-bolly
Update section1.yml
5767769 
Signed-off-by: Kawamata <[email protected]>
@cawamata @uk-bolly
Update section3.yml
a63731b 
Signed-off-by: Kawamata <[email protected]>
@cawamata @uk-bolly
Update section4.yml
33520d7 
Signed-off-by: Kawamata <[email protected]>
@cawamata @uk-bolly
Update section5.yml
6799745 
Signed-off-by: Kawamata <[email protected]>
@georgenalen @uk-bolly
Adjusted 3.5.2.4 to work better with all outgoing and removed unused var
55564ca 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Fixed 3.5.2.4 if 3.5.2.2 is enabled
8304288 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
fixed allow_users/groups
d0f3f15 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Fixed control 1.8.2 to properly format banner
710f921 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Fixed control 1.8.2 to properly format banner
a83b7ce 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed xwindows var to a more generic desktop variable
5230a09 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Fix for issue #17
9f2eec0 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Updated readme for badges
2e9783e 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Added more readme updates
2b8da4d 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Fixed 4.2.1.6 imtcp typo
9f11acc 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Added CONTRIBUTING.rst file
7a32a7a 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
fixed typo in readme links
bf6ed51 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
removed redundant ubuntu18-cis at the top of readme
99e7975 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 1
3bfad36 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 2
a490a9e 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 3
a6c7a17 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 4
b1b42b4 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 5
3f6d9e7 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
Changed layout for section 6
1372d92 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
fixes for issue #25
08d83ad 
Signed-off-by: George Nalen <[email protected]>
@georgenalen @uk-bolly
fix for issue #24 update
9cf1a2b 
Signed-off-by: George Nalen <[email protected]>
uk-bolly and others added 27 commits September 20, 2023 17:12
@uk-bolly
dest to path
313bdc4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fix typo
231a703 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
improved 5.1.8/9
7b1a0d8 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
consistency
39800d8 
Signed-off-by: Mark Bolwell <[email protected]>
@MrSteve81 @uk-bolly
Updated MOdules
8228738 
Signed-off-by: Stephen Williams <[email protected]>
@MrSteve81 @uk-bolly
Updated License
75d7e83 
Signed-off-by: Stephen Williams <[email protected]>
@uk-bolly
updated filesystem mount usage
840e3e5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
4.1.11 updated process list command
020778b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
48d88d4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
05cbe21 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
pre-commit and secrets added
8755841 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
5e458be 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed issues and legacy workflow
a2a0e83 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
new workflow files added
8aaf8db 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint
e6104a6 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
typo
097566a 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated discord link
069e047 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
346baef 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated layout
c83581c 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed files not required
a85269b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
linting
41f4713 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint
0992890 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed legacy files
1ee000c 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed files not required
5939fc4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
linting
9fbb55a 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
856e397 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
ecee45e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly closed this Sep 20, 2023
@uk-bolly uk-bolly deleted the linting branch September 20, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederickw082922 frederickw082922 frederickw082922 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uk-bolly @frederickw082922 @georgenalen @cawamata @hankszeto @MrSteve81