Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point release 3.0.4 breaks AutoPSK #1350

Closed
krauthosting opened this issue Jul 23, 2024 · 4 comments · Fixed by #1401
Closed

point release 3.0.4 breaks AutoPSK #1350

krauthosting opened this issue Jul 23, 2024 · 4 comments · Fixed by #1401
Labels
bug Something isn't working role The issue or pull request is related to Zabbix role

Comments

@krauthosting
Copy link
Contributor

krauthosting commented Jul 23, 2024

SUMMARY

@pyrodie18 @BGmot Hey bros, this again breaks stuff in a minor release 🙀
FYI We originally contributed the whole logic behind zabbix_agent_tlspsk_auto
Again goal was security by default and avoid Zabbix's unencrypted by default.
Breaking commits came for issue #1338 via PR #1343 and released as 3.0.4

ISSUE TYPE
  • Bug Report
COMPONENT NAME

zabbix_agent role

ANSIBLE VERSION
ansible [core 2.16.8]
  config file = /home/ansible/ansible.cfg
  configured module search path = ['/home/ansible/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/dist-packages/ansible
  ansible collection location = /home/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.10.12 (main, Mar 22 2024, 16:50:05) [GCC 11.4.0] (/usr/bin/python3)
  jinja version = 3.0.3
  libyaml = True
OS / ENVIRONMENT / Zabbix Version

Ubuntu 22.04 LTS / Ansible Conroller / Zabbix 6.0 LTS>

STEPS TO REPRODUCE

Enabling zabbix_agent_tlspsk_auto leads now to TLSAccept=psk,unencrypted
Screenshot from 2024-07-23 16-29-31
Beside insecure defaults it also functionally breaks the zabbix_agent role:
Screenshot from 2024-07-23 16-08-56

@pyrodie18 pyrodie18 added bug Something isn't working role The issue or pull request is related to Zabbix role labels Jul 23, 2024
@andrew-landsverk-win
Copy link
Contributor

I notice this issue still affects 3.1.0.

@pyrodie18
Copy link
Collaborator

Yep, no one has submitted a PR for it yet and me and all of the other maintainers are busy on various other things.

@thatradacat
Copy link

As of 3.1.2 the issue is still apparent.

@Thulium-Drake
Copy link
Contributor

You can workaround it by adding the following to your inventory variables:

zabbix_agent_tlsaccept: 'psk'
zabbix_agent_tlsconnect: 'psk'

I'll try to make some time next week to investigate this and make a PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working role The issue or pull request is related to Zabbix role
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants