vmware_guest: remove hardware version number check to avoid updating the restriction everytime

[Tomorrow9]

SUMMARY

Can we remove the hardware version number check in vmware_guest module? or find another better way to do this? or we need to change this restriction every time after vSphere new releases and new hardware version introduced.

ISSUE TYPE

• Bug Report

COMPONENT NAME

vmware_guest

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

try:
                    temp_version = int(temp_version)
                except ValueError:
                    hw_version_check_failed = True

                if temp_version not in range(3, 18):
                    hw_version_check_failed = True

                if hw_version_check_failed:
                    self.module.fail_json(msg="Failed to set hardware.version '%s' value as valid"
                                          " values range from 3 (ESX 2.x) to 17 (ESXi 7.0)." % temp_version)

EXPECTED RESULTS

We do not need to change this range(3, 18) every time when there is new hardware version introduced in new vSphere release, e.g., hardware version 18, 19, etc.

ACTUAL RESULTS

[ansibullbot]

Files identified in the description:

• [plugins/modules/vmware_guest.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/vmware_guest.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Akasurde @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[mariolenz]

I agree, this check doesn't make much sense. Even if the version is theoretically valid, it doesn't mean the module will work. Like using version 18 but the vCenter or ESXi is 6.5. I think we should just remove this check.

I'll do a PR and request your review.

[mariolenz]

@Tomorrow9 Can you pleae have a look at PR #639?

[Tomorrow9]

@Tomorrow9 Can you pleae have a look at PR #639?

Thanks for your quick fixing.