Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add huge_pages_status to postgresql_info output #746

Open
hunleyd opened this issue Oct 7, 2024 · 4 comments
Open

add huge_pages_status to postgresql_info output #746

hunleyd opened this issue Oct 7, 2024 · 4 comments

Comments

@hunleyd
Copy link
Collaborator

hunleyd commented Oct 7, 2024

SUMMARY

With the release of PG 17, we should include the value of huge_pages_status in the output of postgresql_info to make it easy to determine if huge pages are in use by PG or not

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

postgresql_info

ADDITIONAL INFORMATION
- name: Collect PostgreSQL version and extensions
  become: true
  become_user: postgres
  community.postgresql.postgresql_info:
  register: 'pginfo'

- ansible.builtin.assert:
    that:
      - pginfo['huge_pages_status']
    fail_msg: 'PG was not able to allocate huge pages'
@hunleyd
Copy link
Collaborator Author

hunleyd commented Oct 7, 2024

thoughts @Andersson007 ?

@Andersson007
Copy link
Collaborator

@hunleyd SGTM, thanks for reporting the feature request, SGTM, would you like to add it yourself? If no, please add the help wanted label

@hunleyd hunleyd added the help wanted Extra attention is needed label Oct 8, 2024
@hunleyd
Copy link
Collaborator Author

hunleyd commented Oct 8, 2024

i've added the label. i'd love to look at it myself, but if someone can get to it faster, that's great.

@Andersson007 Andersson007 removed the help wanted Extra attention is needed label Oct 10, 2024
@Andersson007
Copy link
Collaborator

@hunleyd i took a look and i see in the output:

        "huge_pages_status": {
            "boot_val": "unknown",
            "context": "internal",
            "max_val": "",
            "min_val": "",
            "pending_restart": false,
            "pretty_val": "off",
            "setting": "off",
            "sourcefile": "",
            "unit": "",
            "vartype": "enum"
        },

or did you mean something different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants