Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userpass auth method needs tests #67

Closed
briantist opened this issue Mar 18, 2021 · 0 comments · Fixed by #192
Closed

userpass auth method needs tests #67

briantist opened this issue Mar 18, 2021 · 0 comments · Fixed by #192
Assignees
Labels
tests Adds or modifies tests

Comments

@briantist
Copy link
Collaborator

SUMMARY

Related: #66

It seems like the userpass auth method may never have been working, at least not with the version that's in the newer auth class (I'm unsure on the deprecated method in hvac).

And there are no tests for userpass so we don't have any way to catch regressions or problems.

The userpass method is easily testable since it has no external dependencies. Putting this issue here to track the need.

This will probably get done as part of the refactor project, when the auth method moves centrally.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Adds or modifies tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant