Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some modules and lookups don't check for hvac import #257

Closed
briantist opened this issue Apr 29, 2022 · 0 comments · Fixed by #259
Closed

Some modules and lookups don't check for hvac import #257

briantist opened this issue Apr 29, 2022 · 0 comments · Fixed by #259
Assignees
@briantist
Labels
bug Something isn't working
Milestone
v2.5.0

Comments

@briantist
Copy link
Collaborator

briantist commented Apr 29, 2022 •
edited
Loading

SUMMARY

It seems I missed checks and friendly errors for hvac import in the early modules and some lookups.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

Modules:

  • vault_login
  • vault_read
  • vault_token_create

Lookups:

  • vault_token_create
  • vault_login
@briantist briantist added the bug Something isn't working label Apr 29, 2022
@briantist briantist added this to the v2.5.0 milestone Apr 29, 2022
@briantist briantist self-assigned this Apr 29, 2022
@briantist briantist mentioned this issue Apr 29, 2022
Merged
@briantist briantist changed the title Some modules don't check for hvac import Some modules and lookups don't check for hvac import Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briantist briantist

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Tests/fill in briantist/community.hashi_vault
1 participant
@briantist