Improve performance of HSTS module

[designfrontier]

Line 13 of security/hsts.js throws a Not Optimized: Inlining bailed out warning when you are profiling monument apps. Also points to line 33 in the same file. Need to get this function to inline nicely for better performance.

https://www.dropbox.com/s/vru0q99afk9tqae/Screenshot%202016-10-06%2021.28.15.png?dl=0

[designfrontier]

See also: GoogleChrome/devtools-docs#53

[shibanovp]

Hi @designfrontier
Please provide more info about the environment because measuring performance is a tough task.

1. OS?
2. Node version
3. How do you debug it? --inspect flag + chrome unstable / chrome canary?

When I tried to reproduce the issue there was no warning.

[designfrontier]

node version 6.7
Running on OS X
--inspect flag plus public chrome

The performance warning itself is tied to GoogleChrome/devtools-docs#53 (comment) and has to do with hidden classes.

I'll check and see if this is reproducible on 6.8 this morning

[shibanovp]

Tested on

Seems that hsts gets optimized. Even with 6.3.0 it is ok.

Maybe this issue specific to some settings? I tried includeSubDomains true and false.

[designfrontier]

I haven't had a chance to dig into this over the weekend... hopefully tonight. It's possible it was something in my env.