Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Changes unsigned #3425

Open
grarco opened this issue Jun 18, 2024 · 2 comments · May be fixed by #3716
Open

Make Changes unsigned #3425

grarco opened this issue Jun 18, 2024 · 2 comments · May be fixed by #3716

Comments

@grarco
Copy link
Contributor

grarco commented Jun 18, 2024

#3393 introduces the Changes type to track the unutilized amount of a spend note so that we can correctly handle fee payment and actual changes. The type is a map from an extended spending key to a I128Sum but these amounts are guaranteed to be non-negative so we should change them to U128Sum.

We can also change from_masp_denominated_i128 to handle unsigned amounts given that this function is used only with changes.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 20, 2024

@grarco To confirm, this should be non-breaking, right?

@grarco
Copy link
Contributor Author

grarco commented Aug 20, 2024

Yes this issue touches the SDK only

@grarco grarco self-assigned this Aug 23, 2024
@grarco grarco linked a pull request Aug 28, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants