Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to update an account's VP #2554

Open
Tracked by #2529
cwgoes opened this issue Feb 7, 2024 · 3 comments · May be fixed by #2561
Open
Tracked by #2529

Remove the ability to update an account's VP #2554

cwgoes opened this issue Feb 7, 2024 · 3 comments · May be fixed by #2561
Assignees
@grarco
Labels
pre-mainnet Must happen before mainnet. security

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Feb 7, 2024

We do not need the ability for an account to update their VP in the initial version of Namada, and we should remove it.
@cwgoes cwgoes added security pre-mainnet Must happen before mainnet. labels Feb 7, 2024
@cwgoes cwgoes mentioned this issue Feb 7, 2024
Closed
17 tasks
@grarco
Copy link
Contributor

grarco commented Feb 8, 2024

Should we also remove the vp hash from InitAccount and just assign the default vp_user to all the established addresses?

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 8, 2024 •
edited
Loading

Should we also remove the vp hash from InitAccount and just assign the default vp_user to all the established addresses?

Yes. Good catch.

@grarco grarco linked a pull request Feb 9, 2024 that will close this issue
Open
2 tasks
@brentstone brentstone added this to the To evaluate milestone Apr 6, 2024
@tzemanovic
Copy link
Member

also rm the vp field from genesis::transactions::ValidatorAccountTx

@cwgoes cwgoes removed this from the Nice to have milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grarco grarco

Labels
pre-mainnet Must happen before mainnet. security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes custom established VPs anoma/namada
4 participants
@tzemanovic @cwgoes @brentstone @grarco