Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCK implementation error #680

Open
JosephChataignon opened this issue Nov 18, 2021 · 0 comments
Open

ROCK implementation error #680

JosephChataignon opened this issue Nov 18, 2021 · 0 comments

Comments

@JosephChataignon
Copy link

There is an error in the implementation of ROCK algorithm. In the original paper describing the algorithm, the authors stress the fact that they use the number of links (defined as common neighbours) between clusters, rather than the number of neighbours, when they chose which clusters should be merged. They say one can obtain a matrix of links by multiplying the adjacency matrix by itself. In the current implementation, the goodness measure uses the adjacency matrix where it should use the links matrix (= adjacency_matrix ^ 2).

I am planning to submit a pull request soon to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant