From d9f638bdde314d7ec55e40df1f4be4e82816b76a Mon Sep 17 00:00:00 2001 From: amandarichardsonn <30413257+amandarichardsonn@users.noreply.github.com> Date: Thu, 18 Apr 2024 16:37:19 -0700 Subject: [PATCH] Remove init_default function (#545) This PR removes the helper function `init_default` and instead implements traditional type narrowing. [ reviewed by @MattToast ] [ committed by @amandarichardsonn ] --- doc/changelog.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/changelog.rst b/doc/changelog.rst index 94a3426af..7751f9cf7 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -19,6 +19,7 @@ To be released at some future point in time Description - Fix race condition for telemetry monitor +- Remove helper function ``init_default`` - Fix telemetry monitor logging errrors for task history - Change default path for entities - Drop Python 3.8 support @@ -44,6 +45,8 @@ Description Detailed Notes - Ensure the telemetry monitor is started prior to launching entities (SmartSim-PR549_) +- Remove helper function ``init_default`` and replace with traditional type + narrowing. (SmartSim-PR545_) - Ensure the telemetry monitor does not track a task_id for a managed task. (SmartSim-PR557_) - The default path for an entity is now the path to the experiment / the @@ -110,6 +113,7 @@ Detailed Notes the previously registered signal handler. (SmartSim-PR535_) .. _SmartSim-PR549: https://github.com/CrayLabs/SmartSim/pull/549 +.. _SmartSim-PR545: https://github.com/CrayLabs/SmartSim/pull/545 .. _SmartSim-PR557: https://github.com/CrayLabs/SmartSim/pull/557 .. _SmartSim-PR533: https://github.com/CrayLabs/SmartSim/pull/533 .. _SmartSim-PR544: https://github.com/CrayLabs/SmartSim/pull/544