Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing in Advanced mode saves CSS but does not apply it to page #87

Closed
ankit opened this issue May 19, 2011 · 5 comments
Closed

Editing in Advanced mode saves CSS but does not apply it to page #87

ankit opened this issue May 19, 2011 · 5 comments

Comments

@ankit
Copy link
Owner

ankit commented May 19, 2011

It does not show live changes on the page. The changes are however saved, as they show up when you refresh the page.

@rduenasf
Copy link
Contributor

You have to use the getValue function to get the current css.

BTW, I was looking for a way to do this:

    // todo: do this in a more foolproof way
    // currently, we are just using an arbitrary value to determine when CodeMirror is finished setting up

And in the google group of CodeMirror, the developer says there's no need to have an onLoad callback, because the constructor returns after CodeMirror has been completely loaded. See here

@ankit
Copy link
Owner Author

ankit commented May 19, 2011

Yeah, I did that to set focus to the URL field.

If you've fix for this issue (Advanced mode), please push. I'm having feeling this was introduced after we updated to jQuery 1.6.1

@ankit
Copy link
Owner Author

ankit commented May 19, 2011

Never mind, issue fixed.

jQuery 1.6.1 has really broken .attr(). .attr() now returns 'undefined' instead of "", and that is causing havoc!

@rduenasf
Copy link
Contributor

I thought you were using CodeMirror now, that's why I suggsted getValue :P

@ankit ankit closed this as completed in 23d4fa7 May 19, 2011
@rduenasf
Copy link
Contributor

I don't get why is that timeout there, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants