Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ktlint configs to the code style file #11996

Closed
BrayanDSO opened this issue Aug 10, 2022 · 5 comments
Closed

Add Ktlint configs to the code style file #11996

BrayanDSO opened this issue Aug 10, 2022 · 5 comments
Labels
Keep Open avoids the stale bot

Comments

@BrayanDSO
Copy link
Member

From #9390 (comment)

Perhaps if we used one of the plugins (this is most popular: https://github.com/jlleitschuh/ktlint-gradle#additional-helper-tasks) and just integrated it's pre-commit hook (and IDEA style file generation) we'd get editor support for style in Android Studio, and we'd get formatting as a pre-commit hook, and everyone else already using that plugin will have solved all the problems we're cutting our teeth on?

I'd like to see a Proof of concept that killed our pre-commit hook and tried integrating that plugin with it's IDEA style + commit hook)

This PR is only for fixing the pre-commit problem. As I found very reasonable to try using the plugin IDEA style as well and the repo's kotlin code style barely exists, I'll peel it to a separate issue.

Originally posted by @BrayanDSO in #11995 (comment)


Here's the code style file. Related to #11852 as well.

@BrayanDSO BrayanDSO changed the title From https://github.com/ankidroid/Anki-Android/issues/9390#issuecomment-950353851 Add Ktlint configs to the code style file Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Oct 9, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
@BrayanDSO BrayanDSO reopened this Oct 16, 2022
@BrayanDSO BrayanDSO removed the Stale label Oct 16, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 15, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
@BrayanDSO BrayanDSO reopened this Dec 22, 2022
@github-actions github-actions bot removed the Stale label Dec 23, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 22, 2023
@BrayanDSO BrayanDSO added Keep Open avoids the stale bot and removed Stale labels May 23, 2023
@david-allison
Copy link
Member

@BrayanDSO Can this be closed out now the ktlint pre-commit hook is working correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open avoids the stale bot
Projects
None yet
Development

No branches or pull requests

2 participants