Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix endpoint response format #126

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix endpoint response format #126

merged 1 commit into from
Mar 24, 2021

Conversation

jalajcodes
Copy link
Member

Description

In #119 I forgot to remove extra code from the response of the controller method.

This PR fixes the wrong response format that was added in #119

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@jalajcodes jalajcodes requested a review from annabauza March 17, 2021 18:07
epicadk
epicadk approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looks good

@epicadk epicadk added the Status: Needs Review PR needs an additional review or a maintainer's review. label Mar 20, 2021
Rahulm2310
Rahulm2310 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@Rahulm2310 Rahulm2310 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
@annabauza Adding ready to merge label as we have 2 approvals.

@Rahulm2310 Rahulm2310 added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Mar 24, 2021
@epicadk epicadk added Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Mar 24, 2021
@epicadk
Copy link
Member

epicadk commented Mar 24, 2021

This needs testing before merging.

@annabauza annabauza merged commit 031e3ee into anitab-org:master Mar 24, 2021
@epicadk
Copy link
Member

epicadk commented Mar 24, 2021

I guess not : /

@epicadk epicadk added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicadk epicadk epicadk approved these changes

@Rahulm2310 Rahulm2310 Rahulm2310 approved these changes

@annabauza annabauza annabauza approved these changes

Assignees
No one assigned
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalajcodes @epicadk @annabauza @Rahulm2310