This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
fix: Removed network call to backend server when transitioning from "Member Profile" to "Send Request" screen. #138
Open
yashhalgaonkar
wants to merge
3
commits into
anitab-org:develop
Choose a base branch
from
yashhalgaonkar:issue-121
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,8 @@ import './bloc.dart'; | |
class MembersPageBloc extends Bloc<MembersPageEvent, MembersPageState> { | ||
final UserRepository userRepository; | ||
int pageNumber = 1; | ||
MembersPageBloc({@required this.userRepository}) : assert(userRepository != null); | ||
MembersPageBloc({@required this.userRepository}) | ||
: assert(userRepository != null); | ||
@override | ||
MembersPageState get initialState => MembersPageInitial(); | ||
|
||
|
@@ -25,47 +26,67 @@ class MembersPageBloc extends Bloc<MembersPageEvent, MembersPageState> { | |
} | ||
} | ||
|
||
Stream<MembersPageState> _mapEventToMembersShowed(MembersPageEvent event) async* { | ||
Stream<MembersPageState> _mapEventToMembersShowed( | ||
MembersPageEvent event) async* { | ||
final currentState = state; | ||
|
||
if (event is MembersPageShowed && !_hasReachedMax(currentState)) { | ||
try { | ||
if (currentState is MembersPageInitial) { | ||
yield MembersPageLoading(); | ||
final List<User> users = await userRepository.getVerifiedUsers(pageNumber); | ||
yield MembersPageSuccess(users: users, hasReachedMax: false); | ||
final List<User> users = | ||
await userRepository.getVerifiedUsers(pageNumber); | ||
final User currentUser = await userRepository.getCurrentUser(); | ||
yield MembersPageSuccess( | ||
users: users, | ||
hasReachedMax: false, | ||
currentUser: currentUser, | ||
); | ||
} | ||
if (currentState is MembersPageSuccess) { | ||
final users = | ||
await userRepository.getVerifiedUsers((currentState.users.length ~/ 10) + 1); | ||
final users = await userRepository | ||
.getVerifiedUsers((currentState.users.length ~/ 10) + 1); | ||
yield users.isEmpty | ||
? currentState.copyWith(hasReachedMax: true) | ||
: MembersPageSuccess( | ||
users: currentState.users + users, | ||
hasReachedMax: false, | ||
currentUser: currentState.currentUser, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here while initializing MembersPageSuccess, we need not make the network call again. So removed it. |
||
); | ||
} | ||
} on Failure catch (failure) { | ||
Logger.root.severe("MembersPageBloc: Failure catched: $failure.message"); | ||
Logger.root | ||
.severe("MembersPageBloc: Failure catched: $failure.message"); | ||
yield MembersPageFailure(failure.message); | ||
} | ||
} | ||
} | ||
|
||
Stream<MembersPageState> _mapEventToMembersRefresh(MembersPageEvent event) async* { | ||
Stream<MembersPageState> _mapEventToMembersRefresh( | ||
MembersPageEvent event) async* { | ||
final currentState = state; | ||
|
||
if (event is MembersPageRefresh) { | ||
try { | ||
yield MembersPageLoading(); | ||
final List<User> users = await userRepository.getVerifiedUsers(pageNumber); | ||
yield MembersPageSuccess(users: users, hasReachedMax: false); | ||
final List<User> users = | ||
await userRepository.getVerifiedUsers(pageNumber); | ||
final User currentUser = (currentState is MembersPageSuccess) | ||
? currentState.currentUser | ||
: await userRepository.getCurrentUser(); | ||
yield MembersPageSuccess( | ||
users: users, | ||
hasReachedMax: false, | ||
currentUser: currentUser, | ||
); | ||
} on Failure catch (failure) { | ||
Logger.root.severe("MembersPageBloc: Failure catched: $failure.message"); | ||
Logger.root | ||
.severe("MembersPageBloc: Failure catched: $failure.message"); | ||
yield state; | ||
} | ||
} | ||
} | ||
} | ||
|
||
bool _hasReachedMax(MembersPageState state) => state is MembersPageSuccess && state.hasReachedMax; | ||
bool _hasReachedMax(MembersPageState state) => | ||
state is MembersPageSuccess && state.hasReachedMax; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This network call will be made when the state is MembersPageInitial. This is a necessary call.