Move documentation files in the docs folder #347
+34,452
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
isabelcosta
reviewed
Jun 25, 2022
| @@ -5,7 +5,7 @@ _**Note**: This is only needed if you want to contribute to the project._ | |||
| If you want to contribute to the project you will have to create your own copy of the project on GitHub. You can do this by clicking the | |||
| **Fork** button that can be found on the top right corner of the [landing page]([https://github.com/anitab-org/anitab-org.github.io]) of the repository. | |||
|
|
|||
| ## [](https://github.com/anitab-org/anitab-org.github.io/wiki/Fork,-Clone-&-Remote#clone)Clone | |||
| ## [](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Fork,-Clone-&-Remote#clone)Clone | |||
There was a problem hiding this comment.
Suggested change
| ## [](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Fork,-Clone-&-Remote#clone)Clone | |
| ## [](https://github.com/anitab-org/anitab-org.github.io/wiki/Fork,-Clone-&-Remote#clone)Clone |
No need for this change, if you are keeping the link of the Wiki :)
isabelcosta
reviewed
Jun 25, 2022
| @@ -19,7 +19,7 @@ where `YOUR_GITHUB_USER_NAME` is your GitHub handle. | |||
|
|
|||
| `git clone https://github.com/anitab-org/anitab-org.github.io` | |||
|
|
|||
| ## [](https://github.com/anitab-org/anitab-org.github.io/wiki/Fork,-Clone-&-Remote#remote)Remote | |||
| ## [](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Fork,-Clone-&-Remote#remote)Remote | |||
There was a problem hiding this comment.
Suggested change
| ## [](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Fork,-Clone-&-Remote#remote)Remote | |
| ## [](https://github.com/anitab-org/anitab-org.github.io/wiki/Fork,-Clone-&-Remote#remote)Remote |
Removing for same reason as above ;)
isabelcosta
reviewed
Jun 25, 2022
| @@ -7,7 +7,7 @@ | |||
| - When developing a new feature, include at least one test when applicable. | |||
| - When submitting a PR, please follow [this template](PULL_REQUEST_TEMPLATE.md) (which will probably be already filled up once you create the PR). | |||
| - When submitting a PR with changes to user interface (e.g.: new screen, ...), please add screenshots to the PR description. | |||
| - When submitting a PR, please follow [testing guidelines](https://github.com/anitab-org/anitab-org.github.io/wiki/Prepare-testing-GitHub-Pages-for-your-PR), copy the link and place it in your PR. | |||
| - When submitting a PR, please follow [testing guidelines](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Prepare-testing-GitHub-Pages-for-your-PR), copy the link and place it in your PR. | |||
There was a problem hiding this comment.
Suggested change
| - When submitting a PR, please follow [testing guidelines](https://github.com/anitab-org/anitab-org.github.io/docs/wiki/Prepare-testing-GitHub-Pages-for-your-PR), copy the link and place it in your PR. | |
| - When submitting a PR, please follow [testing guidelines](https://github.com/anitab-org/anitab-org.github.io/wiki/Prepare-testing-GitHub-Pages-for-your-PR), copy the link and place it in your PR. |
No need to add "docs" to the path, as this is an actual Wiki page. So it does not refer to the wiki file on the repository :)
isabelcosta
requested changes
Jun 25, 2022
There was a problem hiding this comment.
Thank you for contributing @Ayushi271 !
Just a few comments:
- The placing of the files seems to be correct :)
- The changes in
package-lock.jsonare unnecessary so can you please revert the changes to that file? Because these are not related to the issue you're trying to solve - The changes on files under
.githubfolder don't need the changes, since even though the file being moved is calledWiki.mdthis is not being used for the links you've changed - which are pointing to Wiki page of the repository on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # [ISSUE]
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only
As I have made some previous commits but have to delete them that's why I already have moved the files to the doc folder but some links were broken so I fix it in this now it's working fine.