Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of lis_vector_set_values2 #38

Open
vickysharma0812 opened this issue Jun 1, 2024 · 3 comments
Open

Behavior of lis_vector_set_values2 #38

vickysharma0812 opened this issue Jun 1, 2024 · 3 comments

Comments

@vickysharma0812
Copy link

In method lis_vector_set_values2 what is the purposed of this routine. I imagine that this routine performs the following action.

v(start+1:start+count) = value(1:count)

However, why do we set

start=i in the for loop (see lines given below)

start = i;

In addition, this routine throws an error when flag= LIS_INS_VALUE. This is because start-- goes out of the bound.

Regards
Vikas

@anishida
Copy link
Owner

anishida commented Jun 1, 2024

Thank you for your question. I can't say for sure as it is not code I wrote, but it is likely that this is abandoned code. This may be why the error has not been corrected. In fact, it does not appear to be listed in the user guide.

@vickysharma0812
Copy link
Author

Thank you for your question. I can't say for sure as it is not code I wrote, but it is likely that this is abandoned code. This may be why the error has not been corrected. In fact, it does not appear to be listed in the user guide.

Thank for clarification. I have rectified this issue. I have also added some new set and get methods on vector. I can create a PR. If you like you can merge those.

Please wait for the PR.

@anishida
Copy link
Owner

anishida commented Jun 1, 2024

Thank you for your response. We look forward to hearing from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants