Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify json and normal logger #242

Closed
berendsliedrecht opened this issue Dec 19, 2022 · 1 comment · Fixed by #252
Closed

Unify json and normal logger #242

berendsliedrecht opened this issue Dec 19, 2022 · 1 comment · Fixed by #252
Assignees
Labels
enhancement New feature or request

Comments

@berendsliedrecht
Copy link
Member

We can unify the json and normal logger so we just have one logger call and we can log the values for the normal logger and log the entire json when we have the --json flag enabled,

log!({
  "connection_id": "abc-def",
  "invitation_url": "https://..."
})
# Without flag
abc-def
https://...

# With flag
{
  "connection_id": "abc-def",
  "invitation_url": "https://..."
}
@berendsliedrecht berendsliedrecht added the enhancement New feature or request label Dec 19, 2022
@morrieinmaas morrieinmaas self-assigned this Dec 20, 2022
@morrieinmaas
Copy link
Contributor

alos see discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants