Skip to content

Commit 7a25aa7

Browse files
committed
Work around nodejs bug with 'onread' handler
nodejs/node#32590
1 parent 3566234 commit 7a25aa7

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/nntp.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,11 @@ function NNTP(opts) {
8282
this._connectRetries = opts.connectRetries;
8383

8484
var connectOpts = opts.connect;
85-
var supportsOnread = /^v(12\.1\d|1[3-9]|[2-9]\d|\d\d\d)\./.test(process.version); // test if node >= 12.10.0
85+
// although the feature was added in node 12.10.0, it's crashy on Linux until 13.13.0 / 12.16.3
86+
var supportsOnread = (
87+
+process.version.replace(/\.\d+$/, '').replace(/^v/, '') >= 13.13
88+
|| /^v12\.(16\.[3-9]|1[789]\.|[2-9]\d\.)/.test(process.version)
89+
);
8690
if(supportsOnread || !opts.connect.port) {
8791
connectOpts = util.extend({}, opts.connect);
8892
this.opts = util.extend({}, this.opts, {connect: connectOpts});

0 commit comments

Comments
 (0)