Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues and Re-implementing in Python #5

Open
4 of 7 tasks
animerl opened this issue Nov 5, 2022 · 1 comment
Open
4 of 7 tasks

Known issues and Re-implementing in Python #5

animerl opened this issue Nov 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@animerl
Copy link
Owner

animerl commented Nov 5, 2022

  • Rewrite the code in Python
@animerl animerl added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Nov 5, 2022
@aliencaocao
Copy link
Collaborator

aliencaocao commented Dec 9, 2022

How do we handle unclosed brackets? For example {{hello}
Currently I am planning to make it become {(hello:1.05) so it just treats all unclosed brackets as a literal string. But I am not sure if this is how NAI actually does it.

EDIT: tried with current implementation, it simply removes the unclosed brackets. Will follow this behaviour in Python rewrite.

@aliencaocao aliencaocao linked a pull request Dec 9, 2022 that will close this issue
@aliencaocao aliencaocao removed a link to a pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants