Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): update packages to use new forms module #745

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Jun 22, 2016

This PR updates components using form imports to use the new forms module. Should fix #696.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2016
@jelbourn
Copy link
Member

LGTM

Will merge once we cut a release with the old forms, and then we'll do another release with the new forms.

@mmrath
Copy link

mmrath commented Jun 22, 2016

There is no harm doing a release with old forms. But since anyway everyone is going to use new forms, it is probably ok to skip the release with old forms. I am eagerly waiting for the next alpha with new forms.

@kara kara added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jun 25, 2016
@kara
Copy link
Contributor Author

kara commented Jun 25, 2016

Note: This will also have to go in after our RC.2 update.

@kara kara added pr: needs cleanup / tests and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jun 28, 2016
@kara kara force-pushed the forms branch 2 times, most recently from 0ca6173 to 7345baf Compare June 28, 2016 02:38
@TobiasKrogh
Copy link

Hey, great work. Stumbled upon this while looking whether material2 was already working with @angular/forms. Is there a specific reason not to use "@angular/forms" 0.1.1 directly? Just being curious!

@jelbourn jelbourn merged commit 653fcee into angular:master Jun 30, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @angular/forms
5 participants