fix(select): consider value changes via arrow keys on closed select as user actions #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s user actions Currently, the user changing the `md-select` value using the arrow keys on a closed select won't mark the interaction as `isUserInput` in the option's selection event. These change s correct the behavior. Fixes angular#5084.
googlebot
added
the
cla: yes
kara
reviewed
Jun 13, 2017
src/lib/select/select.spec.ts
Outdated
| @@ -29,6 +29,7 @@ import { | |||
| FloatPlaceholderType, | |||
| MD_PLACEHOLDER_GLOBAL_OPTIONS | |||
| } from '../core/placeholder/placeholder-options'; | |||
| import 'rxjs/add/operator/map'; | |||
There was a problem hiding this comment.
Given that we are trying to move away from this syntax, can you refactor to use the explicit symbol?
There was a problem hiding this comment.
Sure, but I would rather do them all the same time when redoing #2652.
|
@kara could you take another look? |
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the user changing the
md-selectvalue using the arrow keys on a closed select won't mark the interaction asisUserInputin the option's selection event. These changes correct the behavior.Fixes #5084.