feat(a11y): add basic focus-trap directive #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
pr: needs review
Accessibility
googlebot
added
the
cla: yes
|
Also R: @hansl |
kara
approved these changes
Sep 23, 2016
| * | ||
| * NOTE: This directive currently uses a very simple (naive) approach to focus trapping. | ||
| * It assumes that the tab order is the same as DOM order, which is not necessarily true. | ||
| * Things like tabIndex > 0, flex `order`, and shadow roots can cause to two to misalign. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara
Very basic approach, as described in the comments.
The template isn't in its own file for now because apparently our build isn't set up to handle
templateUrlfor anything incore/.