fix(sidenav): turn off view encapsulation and refactor css #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P1
googlebot
added
the
cla: yes
| @@ -8,7 +7,6 @@ import {Observable} from 'rxjs/Observable'; | |||
| selector: 'tab-group-demo', | |||
| templateUrl: 'tab-group-demo.html', | |||
| styleUrls: ['tab-group-demo.css'], | |||
| pipes: [AsyncPipe], | |||
There was a problem hiding this comment.
This change was necessary to work with the patched PR.
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @hansl
This change is necessary for the sidenav to continue working with angular/angular#10997 and is blocking that PR's syncing into Google. The PR tightens the css encapsulation such that rules only apply to elements within the view of the component in which they are defined. In this case, the styles for
md-sidenavwere defined in the styles formd-sidenav-layout, so they were no longer being applied to the sidenav element (which is in a different view).I've also refactored the css to reduce the specificity across the board.