Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

requestAnimationFrame still run when set md-progress-circular ng-show='false' #10668

Closed
feichao opened this issue May 16, 2017 · 3 comments
Closed
Assignees
Labels
has: Pull Request A PR has been created to address this issue needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue P3: important Important issues that really should be fixed when possible. resolution: can't reproduce The team is unable to reproduce this issue with the information provided type: performance This issue is related to performance

Comments

@feichao
Copy link

feichao commented May 16, 2017

Actual Behavior:

  • requestAnimationFrame is still running when set md-progress-circular ng-show='false', and the usage of cpu retains 19%
  • when set ng-show='false' or ng-hide='true', the requestAnimationFrame should pause

AngularJS Versions: *

  • AngularJS Version: 1.5.8
  • AngularJS Material Version: v1.1.1

Additional Information:

  • Browser Type: chrome
  • Browser Version: 58
  • OS: Mac OS
@ThomasBurleson
Copy link
Contributor

We will not fix this in AngularJS Material. You are welcome to provide a Pull Request to resolve this for Material 1.1.x.

@Splaktar
Copy link
Member

It would be helpful if you could provide a CodePen that demonstrates this. Here is a starter http://codepen.io/team/AngularMaterial/pen/RrbXyW

@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. labels Nov 21, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar added the needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue label Feb 7, 2018
@Splaktar Splaktar modified the milestones: 1.1.7, - Backlog Feb 7, 2018
@Splaktar Splaktar added the resolution: can't reproduce The team is unable to reproduce this issue with the information provided label Aug 14, 2018
@Splaktar Splaktar removed this from the - Backlog milestone Aug 14, 2018
@Splaktar
Copy link
Member

No demo provided. If you are still seeing this, please submit a new issue using the issue template and providing a CodePen reproduction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue P3: important Important issues that really should be fixed when possible. resolution: can't reproduce The team is unable to reproduce this issue with the information provided type: performance This issue is related to performance
Projects
None yet
Development

No branches or pull requests

3 participants