fix(material-experimental/mdc-slider): thumb incorrectly positioned when inside an overlay #25288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen inside an overlay Fixes an issue where the thumb of an MDC slider wasn't positioned correctly when it has an initial value inside an overlay that is being animated. There are multiple ways to resolve this, but I ended up doing it by removing our logic that skips the first `ResizeObserver` emission since we can get around the performance issues with the `layout` call by reusing the dimensions provided in the callback. Fixes angular#25286.
crisbeto
added
P3
devversion
approved these changes
Jul 15, 2022
| this._resizeTimer = setTimeout(() => { | ||
| // The `layout` call is going to call `getBoundingClientRect` to update the dimensions | ||
| // of the host. Since the `ResizeObserver` already calculated them, we can save some | ||
| // work by returning them instead of having to check the DOM again. |
There was a problem hiding this comment.
Optional nit:
Suggested change
| // work by returning them instead of having to check the DOM again. | |
| // work by caching them instead of having to check the DOM again. |
There was a problem hiding this comment.
The caching isn't permanent though. It gets reset after the layout call.
There was a problem hiding this comment.
I see. I just wasn't sure where you "returned" it, but the comment makes sense regardless.
crisbeto
added a commit
that referenced
this pull request
Jul 15, 2022
…hen inside an overlay (#25288) Fixes an issue where the thumb of an MDC slider wasn't positioned correctly when it has an initial value inside an overlay that is being animated. There are multiple ways to resolve this, but I ended up doing it by removing our logic that skips the first `ResizeObserver` emission since we can get around the performance issues with the `layout` call by reusing the dimensions provided in the callback. Fixes #25286. (cherry picked from commit fb4d7a0)
crisbeto
added a commit
that referenced
this pull request
Jul 15, 2022
…hen inside an overlay (#25288) Fixes an issue where the thumb of an MDC slider wasn't positioned correctly when it has an initial value inside an overlay that is being animated. There are multiple ways to resolve this, but I ended up doing it by removing our logic that skips the first `ResizeObserver` emission since we can get around the performance issues with the `layout` call by reusing the dimensions provided in the callback. Fixes #25286. (cherry picked from commit fb4d7a0)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 21, 2022
…s dragging Fixes an internal bug caused by angular#25288 where a slider was resizing while the user is dragging, causing the thumb to jump around.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 21, 2022
…s dragging Fixes an internal bug caused by angular#25288 where a slider was resizing while the user is dragging, causing the thumb to jump around.
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 24, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.5/14.0.6) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.5/14.0.6) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.0.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1406-chromium-pinball-2022-07-20) [Compare Source](angular/components@14.0.5...14.0.6) ##### material | Commit | Type | Description | | -- | -- | -- | | [cc510216a](angular/components@cc51021) | fix | **autocomplete:** prevent outside clicks from going to other overlays ([#​25243](angular/components#25243)) | | [b73b2fb85](angular/components@b73b2fb) | fix | **checkbox:** incorrect animation state when going from pre-checked to indeterminate ([#​25297](angular/components#25297)) | | [e7b359286](angular/components@e7b3592) | fix | **slider:** add cancelable checks to touchmove and touchend events ([#​25301](angular/components#25301)) | | [d7e422668](angular/components@d7e4226) | fix | **tabs:** disable tab label color transition when animations are disabled ([#​25308](angular/components#25308)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [43bfbac51](angular/components@43bfbac) | fix | **mdc-slider:** thumb incorrectly positioned when inside an overlay ([#​25288](angular/components#25288)) | #### Special Thanks Alka Vats, John Vandenberg, Kristiyan Kostadinov and Oliver Kierepka <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjMyLjExOS4yIn0=--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1469 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Aug 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the thumb of an MDC slider wasn't positioned correctly when it has an initial value inside an overlay that is being animated.
There are multiple ways to resolve this, but I ended up doing it by removing our logic that skips the first
ResizeObserveremission since we can get around the performance issues with thelayoutcall by reusing the dimensions provided in the callback.Fixes #25286.