refactor(material/menu): use separate signature for deprecated constructor parameters #24116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
…uctor parameters Moves the constructor deprecations out into a separate signature in order to make it easier to remove later on and to make the autocompletion in IDEs more accurate. This is something we've wanted to do for a while, but VIewEngine didn't support multiple constructor signatures. Also this is meant as a test to check if anything comes up during the presubmit. If it passes, we can roll this approach out to all constructors.
crisbeto
force-pushed
the
deprecated-constructor-signature
branch
from
e80fdcf to
e0443de
Compare
googlebot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Jan 10, 2022
…uctor parameters (#24116) Moves the constructor deprecations out into a separate signature in order to make it easier to remove later on and to make the autocompletion in IDEs more accurate. This is something we've wanted to do for a while, but VIewEngine didn't support multiple constructor signatures. Also this is meant as a test to check if anything comes up during the presubmit. If it passes, we can roll this approach out to all constructors. (cherry picked from commit b81259e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the constructor deprecations out into a separate signature in order to make it easier to remove later on and to make the autocompletion in IDEs more accurate.
This is something we've wanted to do for a while, but ViewEngine didn't support multiple constructor signatures.
Also this is meant as a test to check if anything comes up during the presubmit. If it passes, we can roll this approach out to all constructors.