Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/sort): view not updated when sort state is changed through binding #19492

Merged
merged 1 commit into from
Mar 7, 2021
Merged

fix(material/sort): view not updated when sort state is changed through binding #19492

merged 1 commit into from
Mar 7, 2021

Conversation

crisbeto
Copy link
Member

Fixes the visible state of the sort header not being updated if it gets changed through the matSortActive binding.

Fixes #19467.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 31, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 31, 2020 08:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 31, 2020
@jelbourn
Copy link
Member

jelbourn commented Jun 9, 2020

@andrewseguin PTAL

@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@crisbeto crisbeto force-pushed the 19467/sort-programmatic-change branch from 62b0e96 to 36bc124 Compare June 15, 2020 20:03
@andrewseguin andrewseguin mentioned this pull request Jun 15, 2020
Closed
@crisbeto crisbeto force-pushed the 19467/sort-programmatic-change branch from 36bc124 to 6912d75 Compare July 15, 2020 19:26
@crisbeto crisbeto force-pushed the 19467/sort-programmatic-change branch from 6912d75 to 5c8d760 Compare July 24, 2020 19:52
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto changed the title fix(sort): view not updated when sort state is changed through binding fix(material/sort): view not updated when sort state is changed through binding Dec 27, 2020
@crisbeto crisbeto force-pushed the 19467/sort-programmatic-change branch from 5c8d760 to cc88c81 Compare December 27, 2020 13:04
@crisbeto
fix(material/sort): view not updated when sort state is changed throu…
44211e4 
…gh binding

Fixes the visible state of the sort header not being updated if it gets changed through
the `matSortActive` binding.

Fixes angular#19467.
@crisbeto crisbeto force-pushed the 19467/sort-programmatic-change branch from cc88c81 to 44211e4 Compare February 13, 2021 13:56
@saithis
Copy link

saithis commented Feb 18, 2021

@crisbeto may I ask why this PR doesn't get merged?

@crisbeto crisbeto mentioned this pull request Mar 3, 2021
Closed
@jelbourn jelbourn added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Mar 3, 2021
@annieyw annieyw merged commit ca7d379 into angular:master Mar 7, 2021
annieyw pushed a commit that referenced this pull request Mar 7, 2021
@crisbeto @annieyw
fix(material/sort): view not updated when sort state is changed throu…
90f7a56 
…gh binding (#19492)

Fixes the visible state of the sort header not being updated if it gets changed through
the `matSortActive` binding.

Fixes #19467.

(cherry picked from commit ca7d379)
This was referenced Mar 11, 2021
Closed
Merged
This was referenced Mar 12, 2021
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Sort Header): Sort only works if columns are updated
7 participants
@crisbeto @jelbourn @saithis @andrewseguin @googlebot @mmalerba @annieyw