Skip to content

Commit 445754e

Browse files
committed
fix: remove circular deps
1 parent 2d9f4c4 commit 445754e

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ env:
3636
matrix:
3737
# Order: a slower build first, so that we don't occupy an idle travis worker waiting for others to complete.
3838
- MODE=lint
39+
- MODE=circular_deps
3940
- MODE=e2e
4041
- MODE=saucelabs_required
4142
- MODE=browserstack_required

package.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@
88
"url": "https://github.com/angular/material2.git"
99
},
1010
"scripts": {
11-
"ci:forbidden-identifiers": "node ./scripts/ci/forbidden-identifiers.js",
11+
"ci:forbidden-identifiers": "node ./scripts/ci/forbidden-identifiers.js",
1212
"build": "ng build",
1313
"demo-app": "ng serve",
1414
"test": "karma start test/karma.conf.js",
1515
"tslint": "tslint -c tslint.json 'src/**/*.ts'",
1616
"stylelint": "stylelint 'src/**/*.scss' --config stylelint-config.json --syntax scss",
17+
"check-circular-deps": "madge --circular ./dist",
1718
"typings": "typings install --ambient",
1819
"postinstall": "npm run typings",
1920
"e2e": "protractor",
@@ -60,13 +61,14 @@
6061
"karma-firefox-launcher": "^0.1.7",
6162
"karma-jasmine": "^0.3.8",
6263
"karma-sauce-launcher": "^0.2.14",
64+
"madge": "^0.5.3",
6365
"node-sass": "^3.4.2",
6466
"protractor": "^3.3.0",
6567
"protractor-accessibility-plugin": "0.1.1",
6668
"sass": "^0.5.0",
6769
"strip-ansi": "^3.0.0",
68-
"symlink-or-copy": "^1.0.1",
6970
"stylelint": "^6.5.1",
71+
"symlink-or-copy": "^1.0.1",
7072
"ts-node": "^0.7.3",
7173
"tslint": "^3.5.0",
7274
"typescript": "^1.9.0-dev",

scripts/ci/build-and-test.sh

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ wait_for_tunnel
1818
if is_lint; then
1919
npm run tslint
2020
npm run ci:forbidden-identifiers
21-
npm run stylelint
21+
npm run stylelint
22+
elif is_circular_deps_check; then
23+
npm run check-circular-deps
2224
elif is_e2e; then
2325
MD_APP=e2e ng serve &
2426
sleep 20

scripts/ci/sources/mode.sh

+4
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@ is_e2e() {
88
is_lint() {
99
[[ "$MODE" = lint ]]
1010
}
11+
12+
is_circular_deps_check() {
13+
[[ "$MODE" = circular_deps ]]
14+
}

0 commit comments

Comments
 (0)