Skip to content

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 25, 2020

Adding experimental support for zero-config authentication with SSR using cookies. This is very much a WIP and has some security concerns I need to look into.

#1500

@jamesdaniels jamesdaniels added this to the 6.2 milestone Nov 25, 2020
@google-cla google-cla bot added the cla: yes label Nov 25, 2020
@jamesdaniels jamesdaniels changed the title feat(afs): experimental server-side auth feat(auth): experimental server-side auth Nov 25, 2020
"@angular/compiler-cli": "^9.0.0 || ^10.0.0 || ^11.0.0",
"@angular/platform-server": "^9.0.0 || ^10.0.0 || ^11.0.0",
"@firebase/app-types": "^0.6.1",
"@nguniversal/express-engine": "^11.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix version

afAuth: AngularFireAuth,
) {
super(options, 'offline', true, settings, platformId, zone, { synchronizeTabs: true }, useEmulator, useAuthEmulator);
afAuth.credential.subscribe(userCredential => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dispose

server.set('views', distFolder);

// TODO rename to __updateSession or something, add to the SSR script
server.post('/createSession', async (req, res) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear at this point I should deploy as seperate cloud function

import { AngularFirestore, SETTINGS, Settings } from '@angular/fire/firestore';
import { USE_EMULATOR as USE_AUTH_EMULATOR } from '@angular/fire/auth';
import { USE_EMULATOR as USE_AUTH_EMULATOR, AngularFireAuth } from '@angular/fire/auth';
import { credential } from 'firebase-admin';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill, autocomplete bug

@jamesdaniels jamesdaniels modified the milestones: 6.2, 7.1 Aug 25, 2021
@jamesdaniels
Copy link
Member Author

Closing as I can probably do something better now with v7/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant