-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(auth): experimental server-side auth #2689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "@angular/compiler-cli": "^9.0.0 || ^10.0.0 || ^11.0.0", | ||
| "@angular/platform-server": "^9.0.0 || ^10.0.0 || ^11.0.0", | ||
| "@firebase/app-types": "^0.6.1", | ||
| "@nguniversal/express-engine": "^11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix version
| afAuth: AngularFireAuth, | ||
| ) { | ||
| super(options, 'offline', true, settings, platformId, zone, { synchronizeTabs: true }, useEmulator, useAuthEmulator); | ||
| afAuth.credential.subscribe(userCredential => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dispose
| server.set('views', distFolder); | ||
|
|
||
| // TODO rename to __updateSession or something, add to the SSR script | ||
| server.post('/createSession', async (req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear at this point I should deploy as seperate cloud function
| import { AngularFirestore, SETTINGS, Settings } from '@angular/fire/firestore'; | ||
| import { USE_EMULATOR as USE_AUTH_EMULATOR } from '@angular/fire/auth'; | ||
| import { USE_EMULATOR as USE_AUTH_EMULATOR, AngularFireAuth } from '@angular/fire/auth'; | ||
| import { credential } from 'firebase-admin'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kill, autocomplete bug
|
Closing as I can probably do something better now with v7/9 |
Adding experimental support for zero-config authentication with SSR using cookies. This is very much a WIP and has some security concerns I need to look into.
#1500