Skip to content

Conversation

@KingDarBoja
Copy link
Contributor

Checklist

Description

Based on #2504 (comment), several methods for AngularFirestoreCollectionGroup, AngularFirestoreCollection and AngularFirestoreDocument now uses generics.

Take into account that not every method from the base API (firebase-js) support generics so I had to use the casting at some test specs.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@KingDarBoja
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@markgoho
Copy link
Contributor

markgoho commented Sep 3, 2020

@KingDarBoja is there some documentation that we could also update as part of this PR?

@KingDarBoja
Copy link
Contributor Author

Well there is no documentation regarding the use of generics on angularfire methods, so that's why I didn't make one for these changes.

@jamesdaniels jamesdaniels added this to the 6.1 milestone Nov 10, 2020
@jamesdaniels
Copy link
Member

Closing in favor of #2649, I was trying to solve merge conflicts with the web editor. Clearly it was not going well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants