-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(firestore): doc and collection methods generic #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): doc and collection methods generic #2573
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@KingDarBoja is there some documentation that we could also update as part of this PR? |
|
Well there is no documentation regarding the use of generics on angularfire methods, so that's why I didn't make one for these changes. |
|
Closing in favor of #2649, I was trying to solve merge conflicts with the web editor. Clearly it was not going well. |
Checklist
yarn install,yarn testrun successfully? yesDescription
Based on #2504 (comment), several methods for
AngularFirestoreCollectionGroup,AngularFirestoreCollectionandAngularFirestoreDocumentnow uses generics.Take into account that not every method from the base API (firebase-js) support generics so I had to use the casting at some test specs.