feat(core): introduce BootstrapContext for improved server bootstrapping
#63562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
changed the title
angular-robot
bot
added
detected: breaking change
alan-agius4
force-pushed
the
main-platform-injector
branch
from
93d4db6 to
a2d0427
Compare
alan-agius4
added
the
target: major
alan-agius4
force-pushed
the
main-platform-injector
branch
4 times, most recently
from
b705644 to
6947b29
Compare
alan-agius4
added
the
action: review
Contributor
Author
|
caretaker note: this requires a separate patch in G3 http://cl/802466606 |
alan-agius4
added
the
merge: caretaker note
alan-agius4
force-pushed
the
main-platform-injector
branch
from
6947b29 to
837b218
Compare
hybrist
approved these changes
Sep 3, 2025
packages/core/schematics/migrations/bootstrap-application-to-server-application/README.md
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
main-platform-injector
branch
from
f93674e to
3615fd4
Compare
hybrist
approved these changes
Sep 4, 2025
josephperrott
approved these changes
Sep 4, 2025
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
Reviewed-for: dev-infra
alan-agius4
force-pushed
the
main-platform-injector
branch
from
9dce5cf to
8dab173
Compare
|
Deployed adev-preview for 697d3a8 to: https://ng-dev-previews-fw--pr-angular-angular-63562-adev-prev-fbt65dr2.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
alan-agius4
force-pushed
the
main-platform-injector
branch
2 times, most recently
from
3776c96 to
669792e
Compare
alan-agius4
force-pushed
the
main-platform-injector
branch
2 times, most recently
from
ff571e6 to
b6e92f0
Compare
alan-agius4
changed the title
BootstrapContext for improved server bootstrapping
alan-agius4
force-pushed
the
main-platform-injector
branch
3 times, most recently
from
f092235 to
8bf80c9
Compare
hybrist
approved these changes
Sep 8, 2025
AndrewKushnir
approved these changes
Sep 9, 2025
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments.
…pping This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests. Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state. The new approach introduces a `BootstrapContext` that is passed to the `bootstrapApplication` function. This context provides a platform reference that is scoped to the individual request, ensuring that each server-side render has an isolated platform injector. This prevents state leakage between concurrent requests and makes the overall process more reliable. BREAKING CHANGE: The server-side bootstrapping process has been changed to eliminate the reliance on a global platform injector. Before: ```ts const bootstrap = () => bootstrapApplication(AppComponent, config); ``` After: ```ts const bootstrap = (context: BootstrapContext) => bootstrapApplication(AppComponent, config, context); ``` A schematic is provided to automatically update `main.server.ts` files to pass the `BootstrapContext` to the `bootstrapApplication` call. In addition, `getPlatform()` and `destroyPlatform()` will now return `null` and be a no-op respectively when running in a server environment.
alan-agius4
force-pushed
the
main-platform-injector
branch
from
48f1cc0 to
0911822
Compare
AndrewKushnir
approved these changes
Sep 9, 2025
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
hybrist
approved these changes
Sep 9, 2025
Contributor
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
alan-agius4
added
action: merge
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests.
Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state.
The new approach introduces a
BootstrapContextthat is passed to thebootstrapApplicationfunction. This context provides a platform reference that is scoped to the individual request, ensuring that each server-side render has an isolated platform injector. This prevents state leakage between concurrent requests and makes the overall process more reliable.BREAKING CHANGE:
The server-side bootstrapping process has been changed to eliminate the reliance on a global platform injector.
Before:
After:
A schematic is provided to automatically update
main.server.tsfiles to pass theBootstrapContextto thebootstrapApplicationcall.In addition,
getPlatform()anddestroyPlatform()will now returnnulland be a no-op respectively when running in a server environment.