fix(render): create svg elements with the right namespace #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,6 +215,10 @@ abstract class AbstractHtml5LibAdapter implements DomAdapter { | |||
| return new Element.tag(tagName); | |||
| } | |||
|
|
|||
| createElementNS(ns, tagName, [doc]) { | |||
| throw 'not implemented'; | |||
There was a problem hiding this comment.
the class is abstract, no need to throw (other places should also be modified)
There was a problem hiding this comment.
@vicb: could you please file an issue for this? There are lots of places where we need to clean this up. For now Tobias' change is fine. The P1 goal is to roll out pre-compiler.
There was a problem hiding this comment.
But then I need to implement it in all sub classes...
| // TODO(tbosch): solve SVG properly once https://github.com/angular/angular/issues/4417 is done | ||
| const XLINK_NAMESPACE = 'http://www.w3.org/1999/xlink'; | ||
| const SVG_NAMESPACE = 'http://www.w3.org/2000/svg'; | ||
| const SVG_ELEMENT_NAMES = CONST_EXPR({ |
Temporary fix for angular#4506
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #4506