Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base_query_list): delegate toString,valueOf to _results array #3004

Closed
wants to merge 1 commit into from
Closed

feat(base_query_list): delegate toString,valueOf to _results array #3004

wants to merge 1 commit into from

Conversation

PatrickJS
Copy link
Member

Goal

better support for #2916 and developers that use |json for QueryList instances

@PatrickJS PatrickJS force-pushed the base_query_toString branch 2 times, most recently from c9d0a63 to 17bcef5 Compare July 13, 2015 08:13
rkirov
rkirov reviewed Jul 14, 2015
View reviewed changes
modules/angular2/src/core/compiler/base_query_list.ts
@@ -35,6 +35,10 @@ export class BaseQueryList<T> {

removeCallback(callback): void { ListWrapper.remove(this._callbacks, callback); }

toString(): string { return this._results.toString(); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to base_query_list.dart too.

@PatrickJS PatrickJS force-pushed the base_query_toString branch 2 times, most recently from 5bf43d2 to 7899dd4 Compare July 14, 2015 02:32
@rkirov rkirov self-assigned this Jul 14, 2015
@rkirov rkirov added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 14, 2015
@rkirov
Copy link
Contributor

rkirov commented Jul 14, 2015

Need to fix dart tests, toString in dart keeps the [. Use this StringWrapper like https://github.com/angular/angular/blob/master/modules/angular2/test/render/dom/shadow_dom/shadow_css_spec.ts#L120 to make the tests pass in both JS and dart.

@PatrickJS PatrickJS force-pushed the base_query_toString branch 2 times, most recently from 323e442 to e2061c6 Compare July 14, 2015 19:26
@tbosch
Copy link
Contributor

tbosch commented Jul 27, 2015

@gdi2290 What is the status here?

@PatrickJS PatrickJS force-pushed the base_query_toString branch from e2061c6 to 4da2986 Compare July 28, 2015 00:06
@PatrickJS PatrickJS force-pushed the base_query_toString branch from 4da2986 to 107a06f Compare July 28, 2015 00:24
@PatrickJS
Copy link
Member Author

sorry I forgot to reply but the status is good to go

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2015
@mary-poppins
Copy link

Merging PR #3004 on behalf of @tbosch to branch presubmit-tbosch-pr-3004.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 10, 2015
@PatrickJS
Copy link
Member Author

I got an email saying this commit had an error on travis
https://travis-ci.org/angular/angular/builds/75006950
there seems to be merge conflicts?

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@mary-poppins
Copy link

Merging PR #3004 on behalf of @tbosch to branch presubmit-tbosch-pr-3004.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@rkirov rkirov closed this in 35a83b4 Aug 14, 2015
@PatrickJS PatrickJS deleted the base_query_toString branch August 14, 2015 04:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rkirov rkirov

Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PatrickJS @rkirov @tbosch @mary-poppins @googlebot