fix(animations): always cleanup players after they have finished internally #13334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
commented
Dec 9, 2016
| const playersByAnimation = this._map.get(element); | ||
| if (playersByAnimation) { | ||
| const player = playersByAnimation[animationName]; | ||
| if (targetPlayer && player !== targetPlayer) return; |
There was a problem hiding this comment.
use a branch for this if
|
Reviewed in person with @tbosch |
matsko
force-pushed
the
fix_pending_players
branch
from
5038326
to
54a2322
Compare
matsko
added
pr_state: LGTM
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13333
Closes #13334
cc @kara