Improvements for Closure Compiler compilation

example/personalLog/personalLog.js

@@ -46,7 +46,7 @@ app.controller('LogCtrl', ['$cookieStore', '$scope', function LogCtrl($cookieSto
 
   /**
    * Persistently removes a log from logs.
-   * @param {object} log The log to remove.
+   * @param {Object} log The log to remove.
    */
   $scope.rmLog = function(log) {
     for ( var i = 0; i < logs.length; i++) {

src/Angular.js

@@ -51,7 +51,7 @@ function fromCharCode(code) {return String.fromCharCode(code);}
 
 var Error             = window.Error,
     /** holds major version number for IE or NaN for real browsers */
-    msie              = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]),
+    msie              = atoi((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]),
     jqLite,           // delay binding since jQuery could be loaded after us.
     jQuery,           // delay binding
     slice             = [].slice,
@@ -86,10 +86,10 @@ var Error             = window.Error,
      expect(log).toEqual(['name: misko', 'gender:male']);
    </pre>
  *
- * @param {Object|Array} obj Object to iterate over.
+ * @param {Object|Array|undefined} obj Object to iterate over.
  * @param {Function} iterator Iterator function.
  * @param {Object=} context Object to become context (`this`) for the iterator function.
- * @returns {Object|Array} Reference to `obj`.
+ * @returns {Object|Array|undefined} Reference to `obj`.
  */
 function forEach(obj, iterator, context) {
   var key;
@@ -184,9 +184,9 @@ function nextUid() {
  * to `dst`. You can specify multiple `src` objects.
  *
  * @param {Object} dst Destination object.
- * @param {...Object} src Source object(s).
+ * @param {...Object} var_args Source object(s).
  */
-function extend(dst) {
+function extend(dst, var_args) {
   forEach(arguments, function(obj){
     if (obj !== dst) {
       forEach(obj, function(value, key){
@@ -197,7 +197,7 @@ function extend(dst) {
   return dst;
 }
 
-function int(str) {
+function atoi(str) {
   return parseInt(str, 10);
 }
 
@@ -330,7 +330,7 @@ function isNumber(value){return typeof value == 'number';}
  * @returns {boolean} True if `value` is a `Date`.
  */
 function isDate(value){
-  return toString.apply(value) == '[object Date]';
+  return toString.apply(/** @type {Object} */ (value)) == '[object Date]';
 }
 
 
@@ -346,7 +346,7 @@ function isDate(value){
  * @returns {boolean} True if `value` is an `Array`.
  */
 function isArray(value) {
-  return toString.apply(value) == '[object Array]';
+  return toString.apply(/** @type {Object} */ (value)) == '[object Array]';
 }
 
 
@@ -372,7 +372,7 @@ function isFunction(value){return typeof value == 'function';}
  * @returns {boolean} True if `obj` is a window obj.
  */
 function isWindow(obj) {
-  return obj && obj.document && obj.location && obj.alert && obj.setInterval;
+  return Boolean(obj && obj.document && obj.location && obj.alert && obj.setInterval);
 }
 
 
@@ -403,18 +403,18 @@ function trim(value) {
  * @description
  * Determines if a reference is a DOM element (or wrapped jQuery element).
  *
- * @param {*} value Reference to check.
+ * @param {*} node Reference to check.
  * @returns {boolean} True if `value` is a DOM element (or wrapped jQuery element).
  */
 function isElement(node) {
-  return node &&
+  return Boolean(node &&
     (node.nodeName  // we are a direct element
-    || (node.bind && node.find));  // we have a bind and find method part of jQuery API
+    || (node.bind && node.find)));  // we have a bind and find method part of jQuery API
 }
 
 /**
  * @param str 'key1,key2,...'
- * @returns {object} in the form of {key1:true, key2:true, ...}
+ * @returns {Object} in the form of {key1:true, key2:true, ...}
  */
 function makeMap(str){
   var obj = {}, items = str.split(","), i;
@@ -530,16 +530,16 @@ function isLeafNode (node) {
 function copy(source, destination){
   if (isWindow(source) || isScope(source)) throw Error("Can't copy Window or Scope");
   if (!destination) {
-    destination = source;
     if (source) {
       if (isArray(source)) {
-        destination = copy(source, []);
+        return copy(source, []);
       } else if (isDate(source)) {
-        destination = new Date(source.getTime());
+        return new Date(source.getTime());
       } else if (isObject(source)) {
-        destination = copy(source, {});
+        return copy(source, {});
       }
     }
+    return source;
   } else {
     if (source === destination) throw Error("Can't copy equivalent objects or arrays");
     if (isArray(source)) {
@@ -653,15 +653,15 @@ function sliceArgs(args, startIndex) {
  *
  * @description
  * Returns a function which calls function `fn` bound to `self` (`self` becomes the `this` for
- * `fn`). You can supply optional `args` that are are prebound to the function. This feature is also
+ * `fn`). You can supply optional `var_args` that are are prebound to the function. This feature is also
  * known as [function currying](http://en.wikipedia.org/wiki/Currying).
  *
  * @param {Object} self Context which `fn` should be evaluated in.
  * @param {function()} fn Function to be bound.
- * @param {...*} args Optional arguments to be prebound to the `fn` function call.
+ * @param {...*} var_args Optional arguments to be prebound to the `fn` function call.
  * @returns {function()} Function that wraps the `fn` with all the specified bindings.
  */
-function bind(self, fn) {
+function bind(self, fn, var_args) {
   var curryArgs = arguments.length > 2 ? sliceArgs(arguments, 2) : [];
   if (isFunction(fn) && !(fn instanceof RegExp)) {
     return curryArgs.length
@@ -712,7 +712,7 @@ function toJsonReplacer(key, value) {
  * @returns {string} Jsonified string representing `obj`.
  */
 function toJson(obj, pretty) {
-  return JSON.stringify(obj, toJsonReplacer, pretty ? '  ' : null);
+  return window.JSON.stringify(obj, toJsonReplacer, pretty ? '  ' : null);
 }
 
 
@@ -729,7 +729,7 @@ function toJson(obj, pretty) {
  */
 function fromJson(json) {
   return isString(json)
-      ? JSON.parse(json)
+      ? window.JSON.parse(json)
       : json;
 }
 
@@ -767,7 +767,8 @@ function startingTag(element) {
  * @returns Object.<(string|boolean)>
  */
 function parseKeyValue(/**string*/keyValue) {
-  var obj = {}, key_value, key;
+  var obj = {};
+  var key_value, key;
   forEach((keyValue || "").split('&'), function(keyValue){
     if (keyValue) {
       key_value = keyValue.split('=');
@@ -832,7 +833,7 @@ function encodeUriQuery(val, pctEncodeSpaces) {
  * @name ng.directive:ngApp
  *
  * @element ANY
- * @param {angular.Module} ngApp an optional application
+ * @param {angular.Module} bootstrap an optional application
  *   {@link angular.module module} name to load.
  *
  * @description
@@ -908,7 +909,7 @@ function angularInit(element, bootstrap) {
  * See: {@link guide/bootstrap Bootstrap}
  *
  * @param {Element} element DOM element which is the root of angular application.
- * @param {Array<String|Function>=} modules an array of module declarations. See: {@link angular.module modules}
+ * @param {Array.<String|Function>=} modules an array of module declarations. See: {@link angular.module modules}
  * @returns {AUTO.$injector} Returns the newly created injector for this app.
  */
 function bootstrap(element, modules) {
@@ -961,6 +962,9 @@ function bindJQuery() {
 
 /**
  * throw error of the argument is falsy.
+ * @param {*} arg
+ * @param {string=} name
+ * @param {string=} reason
  */
 function assertArg(arg, name, reason) {
   if (!arg) {
@@ -969,7 +973,12 @@ function assertArg(arg, name, reason) {
   return arg;
 }
 
-function assertArgFn(arg, name, acceptArrayAnnotation) {
+/**
+ * @param {*} arg
+ * @param {string} name
+ * @param {boolean=} acceptArrayAnnotation
+ */
+ function assertArgFn(arg, name, acceptArrayAnnotation) {
   if (acceptArrayAnnotation && isArray(arg)) {
       arg = arg[arg.length - 1];
   }

src/apis.js

@@ -33,6 +33,8 @@ function hashKey(obj) {
 
 /**
  * HashMap which can use objects as keys
+ * @param {(Object|Array)=} array
+ * @constructor
  */
 function HashMap(array){
   forEach(array, this.put, this);
@@ -69,6 +71,7 @@ HashMap.prototype = {
 /**
  * A map where multiple values can be added to the same key such that they form a queue.
  * @returns {HashQueueMap}
+ * @constructor
  */
 function HashQueueMap() {}
 HashQueueMap.prototype = {

src/auto/injector.js

@@ -159,7 +159,7 @@ function annotate(fn) {
  * Create a new instance of JS type. The method takes a constructor function invokes the new operator and supplies
  * all of the arguments to the constructor function as specified by the constructor annotation.
  *
- * @param {function} Type Annotated constructor function.
+ * @param {function()} Type Annotated constructor function.
  * @param {Object=} locals Optional object. If preset then any argument names are read from this object first, before
  *   the `$injector` is consulted.
  * @returns {Object} new instance of `Type`.
@@ -583,12 +583,14 @@ function createInjector(modulesToLoad) {
     }
 
     function instantiate(Type, locals) {
-      var Constructor = function() {},
-          instance, returnedValue;
+      /**
+       * @constructor
+       */
+      var Constructor = function() {};
 
       Constructor.prototype = (isArray(Type) ? Type[Type.length - 1] : Type).prototype;
-      instance = new Constructor();
-      returnedValue = invoke(Type, instance, locals);
+      var instance = new Constructor();
+      var returnedValue = invoke(Type, instance, locals);
 
       return isObject(returnedValue) ? returnedValue : instance;
     }

src/jqLite.js

@@ -71,14 +71,14 @@
  * - `inheritedData()` - same as `data()`, but walks up the DOM until a value is found or the top
  *   parent element is reached.
  *
- * @param {string|DOMElement} element HTML string or DOMElement to be wrapped into jQuery.
+ * @param {string|Element} element HTML string or Element to be wrapped into jQuery.
  * @returns {Object} jQuery object.
  */
 
-var jqCache = JQLite.cache = {},
-    jqName = JQLite.expando = 'ng-' + new Date().getTime(),
-    jqId = 1,
-    addEventListenerFn = (window.document.addEventListener
+var jqCache = JQLite.cache = {};
+var jqName = JQLite.expando = 'ng-' + new Date().getTime();
+var jqId = 1;
+var addEventListenerFn = (window.document.addEventListener
       ? function(element, type, fn) {element.addEventListener(type, fn, false);}
       : function(element, type, fn) {element.attachEvent('on' + type, fn);}),
     removeEventListenerFn = (window.document.removeEventListener
@@ -112,6 +112,10 @@ function camelCase(name) {
 //
 /////////////////////////////////////////////
 
+/**
+ * @param {string} name
+ * @param {boolean=} dispatchThis
+ */
 function JQLitePatchJQueryRemove(name, dispatchThis) {
   var originalJqFn = jQuery.fn[name];
   originalJqFn = originalJqFn.$original || originalJqFn;
@@ -146,6 +150,10 @@ function JQLitePatchJQueryRemove(name, dispatchThis) {
 }
 
 /////////////////////////////////////////////
+
+/**
+ * @constructor
+ */
 function JQLite(element) {
   if (element instanceof JQLite) {
     return element;
@@ -181,6 +189,11 @@ function JQLiteDealoc(element){
   }
 }
 
+/**
+ * @param {Object} element
+ * @param {string=} type
+ * @param {function()=} fn
+ */
 function JQLiteUnbind(element, type, fn) {
   var events = JQLiteExpandoStore(element, 'events'),
       handle = JQLiteExpandoStore(element, 'handle');
@@ -216,6 +229,11 @@ function JQLiteRemoveData(element) {
   }
 }
 
+/**
+ * @param {Object} element
+ * @param {string} key
+ * @param {*=} value
+ */
 function JQLiteExpandoStore(element, key, value) {
   var expandoId = element[jqName],
       expandoStore = jqCache[expandoId || -1];
@@ -299,6 +317,11 @@ function JQLiteController(element, name) {
   return JQLiteInheritedData(element, '$' + (name || 'ngController' ) + 'Controller');
 }
 
+/**
+ * @param {Object} element
+ * @param {string} name
+ * @param {*=} value
+ */
 function JQLiteInheritedData(element, name, value) {
   element = jqLite(element);
 
@@ -329,7 +352,7 @@ var JQLitePrototype = JQLite.prototype = {
 
     this.bind('DOMContentLoaded', trigger); // works for modern browsers and IE9
     // we can not use jqLite since we are not done loading and jQuery could be loaded later.
-    JQLite(window).bind('load', trigger); // fallback to window.onload for others
+    new JQLite(window).bind('load', trigger); // fallback to window.onload for others
   },
   toString: function() {
     var value = [];

src/loader.js

@@ -58,7 +58,7 @@ function setupModuleLoader(window) {
      * {@link angular.bootstrap} to simplify this process for you.
      *
      * @param {!string} name The name of the module to create or retrieve.
-     * @param {Array.<string>=} requires If specified then new module is being created. If unspecified then the
+     * @param {Array.<string>} requires If specified then new module is being created. If unspecified then the
      *        the module is being retrieved for further configuration.
      * @param {Function} configFn Optional configuration function for the module. Same as
      *        {@link angular.Module#config Module#config()}.
@@ -212,7 +212,7 @@ function setupModuleLoader(window) {
            * @ngdoc method
            * @name angular.Module#run
            * @methodOf angular.Module
-           * @param {Function} initializationFn Execute this function after injector creation.
+           * @param {Function} block Execute this function after injector creation.
            *    Useful for application initialization.
            * @description
            * Use this method to register work which should be performed when the injector is done
@@ -233,7 +233,7 @@ function setupModuleLoader(window) {
         /**
          * @param {string} provider
          * @param {string} method
-         * @param {String=} insertMethod
+         * @param {string=} insertMethod
          * @returns {angular.Module}
          */
         function invokeLater(provider, method, insertMethod) {