Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

don't use the name of the angular script to look for ng:autobind #621

Closed
IgorMinar opened this issue Oct 25, 2011 · 0 comments
Closed

don't use the name of the angular script to look for ng:autobind #621

IgorMinar opened this issue Oct 25, 2011 · 0 comments

Comments

@IgorMinar
Copy link
Contributor

We currently set restrictions on angular script filename in order to know where to look for ng:autobind.

This has burned several people, as it is not obvious that things work this way and it also means that if angular file is concatinated with another file, the resulting file must be called angular.something.js.

The filename restriction could be dropped if we simply looked for these attributes on the last script tag in the DOM.

This would obviously not work well for async loaded scripts (or if angular.js is included by a custom script loader), but in this case, ng:autobind can't be used anyway, and the developer will have to imperatively bootstrap the app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant