Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($http): return responseText on IE8 for requests with responseType set #5636

Closed
wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

Closes #4464
Closes #4738

@ghost ghost assigned caitp Jan 5, 2014
@IgorMinar
Copy link
Contributor Author

@caitp can you please review?

@caitp
Copy link
Contributor

caitp commented Jan 5, 2014

If my understanding is correct, it was possible previously for people to set responseType, and this caused us to send xhr.response (which may not have been available) to the callback rather than xhr.responseText?

Reading the code, this looks okay, and I'm not sure this should hurt any of the more evergreen browsers. If I have time, then I might set up a quick test app just to try some things out, but nothing jumps out as being super broken, for what is being addressed.

@ghost ghost assigned IgorMinar Jan 6, 2014
@ricochet1k
Copy link

I just hit this exact problem on IE9, and the change does fix it. It should be noted somewhere that the responseType is an XHR thing and not an Angular thing, because for example, responseType:'json' gives json responses on newer browsers, and a string on IE9.

@IgorMinar IgorMinar closed this in a9cccbe Jan 10, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$http success callback data undefined in IE (1.2.0 rc3) responseText is still buggy on ie8
3 participants