Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($http): allow sending Blob data using $http #5012

Closed
wants to merge 1 commit into from

Conversation

bbaia
Copy link
Contributor

@bbaia bbaia commented Nov 18, 2013

Current workaround is to set $http config.transformRequest property to null.

@mb-dev
Copy link

mb-dev commented Dec 14, 2013

+1

@igienger
Copy link

+1!

@pkozlowski-opensource
Copy link
Member

@bbaia thank you for this pull request. This one looks good to me, just left one small comment.

Could you please do the change, rebase on top of the current master and force push your changes to trigger TravisCI build?

Also please make sure to sign the CLA as described here: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#cla

@bbaia
Copy link
Contributor Author

bbaia commented Mar 2, 2014

Done!

@caitp
Copy link
Contributor

caitp commented Mar 2, 2014

looks okay to me as well

@pkozlowski-opensource
Copy link
Member

OK, let's wait TravisCI has to say and let's merge it if given thumbs up

@pkozlowski-opensource
Copy link
Member

@bbaia looks like TravisCI got a bit upset: https://travis-ci.org/angular/angular.js/jobs/19926829

@bbaia
Copy link
Contributor Author

bbaia commented Mar 2, 2014

Grrr... He is suceptible!
Removed the trailing whitespace, looks OK now!

@linclark
Copy link
Contributor

@btford, looks like this one was just stalled on a fail and was already approved by @caitp and @pkozlowski-opensource. Passing now, so looks like it's RTBM.

@pkozlowski-opensource
Copy link
Member

It landed, thnx @bbaia !

IgorMinar pushed a commit that referenced this pull request Mar 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants