Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(Angular.js): Add Closure externs for angular.$q.Promise.finally #4757

Closed
wants to merge 3 commits into from

Conversation

bigcmos
Copy link
Contributor

@bigcmos bigcmos commented Nov 2, 2013

First pull request. Please let me know if I need to change anything.

@petebacondarwin
Copy link
Contributor

@bigcmos - thanks for this PR. It looks like you have read https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md.

Can you ensure that you have signed the CLA?

You should get used to git rebase rather than merging branches. Ideally, your PR should contain one commit per major change (one in this case).

@IgorMinar
Copy link
Contributor

lgtm, but we need CLA signature

@IgorMinar IgorMinar closed this Nov 4, 2013
@IgorMinar
Copy link
Contributor

accidental close.. reopening. :)

@IgorMinar IgorMinar reopened this Nov 4, 2013
@IgorMinar
Copy link
Contributor

no CLA, punting until 1.2.1

@bigcmos
Copy link
Contributor Author

bigcmos commented Nov 5, 2013

I've signed the electronic CLA. What else is needed?

OOO, may be slow to reply.

~D
On Nov 5, 2013 12:34 PM, "Igor Minar" [email protected] wrote:

no CLA, punting until 1.2.1


Reply to this email directly or view it on GitHubhttps://github.com//pull/4757#issuecomment-27820218
.

@IgorMinar IgorMinar closed this in caeb740 Jan 5, 2014
@IgorMinar
Copy link
Contributor

merged. thanks!

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants