Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngRepeat): handle iteration over identical obj values #2806

Closed
wants to merge 1 commit into from

Conversation

worrel
Copy link
Contributor

@worrel worrel commented May 27, 2013

Modifies default trackByIdFn to factor both key and value into hashKey
for non-array primitive (i.e. index not provided) values

Closes #2787

Modifies default trackByIdFn to factor both key and value into hashKey
for non-array primitive (i.e. index not provided) values

Close angular#2787
@petebacondarwin
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@jeffbcross
Copy link
Contributor

@worrel can you sign the CLA so we can review this?

@worrel
Copy link
Contributor Author

worrel commented Jul 18, 2013

Hi, I just signed it again, let me know if you don't see it (I had previously signed it before generating the PR)

@IgorMinar IgorMinar closed this in 47a2a98 Jul 24, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-repeat throws "Duplicates in a repeater" iterating over an object with identical values
3 participants