Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Doc examples: 'Edit in Plunker' links don't always give you working code #1728

Closed
davemerrill opened this issue Dec 19, 2012 · 2 comments
Closed

Comments

@davemerrill
Copy link

Ex: http://docs.angularjs.org/api/ng.directive:ngView

There are two issues there:

  • Apparently there's a problem with the Plunker API that "doesn't take module names
    into account". I'm not entirely certain what the exact problem is, or if there's a way to build the example that works around it; see this discussion for a little more info:
    https://groups.google.com/forum/?fromgroups=#!topic/angular/ng6LGzr53po
    Of course if there's an issue with that external API, it would need to be fixed there, if it can't be worked around.
  • The code example uses HTML5 router mode, arguably best practice, but it requires server setup that Plunker/JSFiddle won't have. Suggest a simple note to that effect next to the sample, describing the (hopefully simple) changes needed to work on the sharing sites.
@sirkitree
Copy link

It looks like the link above is now broken. I get a blank page.
angularjs error page not found 2014-01-20 05-58-07

I think the valid link is now http://docs.angularjs.org/api/ngRoute.directive:ngView

Secondly, the plunkr seems to work just fine now. I followed the link to the google group discussion, but it doesn't really say they changed anything, so I'm not sure why it works now. Perhaps the example changed? So I think both of your bullet points above have been taken care of at this point.

I can't close this issue, so just reporting my findings. Please close if you can confirm.

@pkozlowski-opensource
Copy link
Member

Thnx @sirkitree, I've just tested both plunker and jsFiddle and indeed things are in order now. AFAIK the original problem was that not all the required files were correctly included in generated plunks / fiddles.

Once again, thnx for looking into this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants