Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular) : fix incorrect budget calculation #29234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

santoshyadavdev
Copy link
Contributor

Fixes #29040

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29040

What is the new behavior?

It uses kb value from packages/angular/build/src/utils/bundle-calculator.ts so there is no difference in value when running tests

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@santoshyadavdev santoshyadavdev force-pushed the fix-incorect-budget-warning branch from 656defa to 3394f77 Compare December 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Budget warnings calculated incorrectly with esbuild builder
1 participant