Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(@angular-devkit/build-angular): additional unit tests for esbuild builder #24746

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Feb 17, 2023

The following unit tests have been ported over to test the experimental esbuild-based browser application builder:

  • baseHref option
  • crossOrigin option
  • TypeScript path mapping behavior

@clydin clydin added the target: major This PR is targeted for the next major release label Feb 17, 2023
…d builder

The following unit tests have been ported over to test the experimental esbuild-based
browser application builder:
* `baseHref` option
* `crossOrigin` option
* TypeScript path mapping behavior
@clydin clydin changed the title test(@angular-devkit/build-angular): additional unit tests to esbuild builder options test(@angular-devkit/build-angular): additional unit tests for esbuild builder Feb 17, 2023
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 17, 2023
@clydin clydin requested a review from alan-agius4 February 17, 2023 21:33
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 21, 2023
@alan-agius4 alan-agius4 linked an issue Feb 21, 2023 that may be closed by this pull request
1 task
@angular-robot angular-robot bot merged commit 4c53c8f into angular:main Feb 21, 2023
@clydin clydin deleted the esbuild/tests branch February 21, 2023 12:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Esbuild builder - support TypeScript path mappings
2 participants