Clear all filters remove the custom filter options

[abhisb]

When I click the clear all filters option from the table menu, filter data gets cleared and worked fine, but it has cleared the custom filter option I have added for two column fields. After then, custom filters are not working based on the conditions I have added. Please find the sample code I have created in Plunkr

In the provided sample code, age filters are working fine based on the filter conditions added. When selecting the clear all filters option, it clear all the filter text entered, after then text entered in age filter ie: greater than or less than is filtered based on default contains only and the custom filter I have added was not filtered anymore. It should be a major bug in business perspective.

[prathyushkp]

I am also facing same issue.
ui-grid.js is having a code to clear the filter ‘condition’ to ‘undefined’ when “Clear All Filter” option is selected from Grid Menu.

file: ui-grid.js

 var clearFilters = [{
        title: i18nService.getSafeText('gridMenu.clearAllFilters'),
        action: function ($event) {
          $scope.grid.clearAllFilters(undefined, true, undefined);
        },
        shown: function() {
          return $scope.grid.options.enableFiltering;
        },
        order: 100
      }];
      menuItems = menuItems.concat( clearFilters );

clearConditions argument value is always "true".

  Grid.prototype.clearAllFilters = function clearAllFilters(refreshRows, clearConditions, clearFlags) {
    // Default `refreshRows` to true because it will be the most commonly desired behaviour.
    if (refreshRows === undefined) {
      refreshRows = true;
    }
    if (clearConditions === undefined) {
      clearConditions = false;
    }
    if (clearFlags === undefined) {
      clearFlags = false;
    }

    this.columns.forEach(function(column) {
      column.filters.forEach(function(filter) {
        filter.term = undefined;

        if (clearConditions) {
          filter.condition = undefined;
        }

        if (clearFlags) {
          filter.flags = undefined;
        }
      });
    });

    if (refreshRows) {
      return this.refreshRows();
    }
  };

any solution to this issue?

[lebolo]

Can probably close this issue and use #4657 instead.

[mportuga]

Closed by #5361