Skip to content

Commit

Permalink
fix(less): update less file references
Browse files Browse the repository at this point in the history
Ensure less files deployed with NPM and Bower can be compiled
individually

BREAKING CHANGE: feature less files have been moved to the root of the
less folder.
  • Loading branch information
Portugal, Marcelo authored and mportuga committed Dec 21, 2018
1 parent c13c931 commit 47c1239
Show file tree
Hide file tree
Showing 19 changed files with 69 additions and 17 deletions.
5 changes: 3 additions & 2 deletions grunt/aliases.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = function (grunt, options) {

// Build with no testing
'build': ['ngtemplates', 'concat', 'uglify', 'less', 'uidocs-generator', 'copy:font_dist', 'copy:site', 'copy:less_customizer',],
'build:less_dist': ['copy:less_dist', 'replace:less_dist'],

// Auto-test tasks for development
'autotest:unit': ['karmangular:start'],
Expand Down Expand Up @@ -48,10 +49,10 @@ module.exports = function (grunt, options) {
var currentTag = semver.clean( util.getCurrentTag() );

if (currentTag) {
baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'build:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
}
else {
baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release'];
baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'build:less_dist', 'cut-release'];
}

return baseTasks;
Expand Down
19 changes: 19 additions & 0 deletions grunt/replace.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module.exports = {
less_dist: {
options: {
patterns: [
{
match: /..\/..\/..\/core\/src\/less\//g,
replace: './'
}
]
},
files: [
{
expand: true,
src: '<%= dist %>/release/less/*.less',
dest: './'
}
]
}
};
31 changes: 31 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"grunt-karma": "~2.0.0",
"grunt-newer": "^1.3.0",
"grunt-protractor-runner": "^5.0.0",
"grunt-replace": "^1.0.1",
"grunt-shell-spawn": "~0.3.10",
"grunt-uidocs-generator": "^0.6.1",
"hoek": "^5.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/cellnav/src/less/cellNav.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-cell-focus {
outline: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/edit/src/less/edit.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-cell {
input {
Expand Down
2 changes: 1 addition & 1 deletion packages/empty-base-layer/src/less/emptyBaseLayer.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-viewport .ui-grid-empty-base-layer-container {
position: absolute;
Expand Down
2 changes: 1 addition & 1 deletion packages/expandable/src/less/expandable.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.expandableRow {
.ui-grid-row {
Expand Down
2 changes: 1 addition & 1 deletion packages/exporter/src/less/exporter.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-exporter-header {
}
2 changes: 1 addition & 1 deletion packages/grouping/src/less/grouping.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-tree-header-row {
font-weight: bold !important;
Expand Down
2 changes: 1 addition & 1 deletion packages/importer/src/less/importer.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-importer-header {
}
2 changes: 1 addition & 1 deletion packages/move-columns/src/less/colMovable.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.movingColumn {
position: absolute;
Expand Down
2 changes: 1 addition & 1 deletion packages/pinning/src/less/pinning.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-pinned-container {
position: absolute;
Expand Down
2 changes: 1 addition & 1 deletion packages/resize-columns/src/less/column-resizer.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-column-resizer {
top: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/row-edit/src/less/rowEdit.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-row-saving {
.ui-grid-cell {
Expand Down
2 changes: 1 addition & 1 deletion packages/selection/src/less/selection.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-row.ui-grid-row-selected > [ui-grid-row] > .ui-grid-cell {
background-color: @rowSelected;
Expand Down
2 changes: 1 addition & 1 deletion packages/tree-base/src/less/tree-base.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-tree-row-header-buttons.ui-grid-tree-header {
cursor: pointer;
Expand Down
2 changes: 1 addition & 1 deletion packages/tree-view/src/less/tree-view.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-tree-header-row {
font-weight: bold !important;
Expand Down
2 changes: 1 addition & 1 deletion packages/validate/src/less/validate.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../../../core/src/less/variables';
@import (reference) '../../../core/src/less/variables';

.ui-grid-cell-contents.invalid {
border: @invalidValueBorder;
Expand Down

0 comments on commit 47c1239

Please sign in to comment.