Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce flicker when resizing horizontally #2997

Closed
Archelyst opened this issue Mar 12, 2015 · 2 comments · Fixed by #3371
Closed

reduce flicker when resizing horizontally #2997

Archelyst opened this issue Mar 12, 2015 · 2 comments · Fixed by #3371
Assignees
@c0bra
Labels
type: bug
Milestone
3.0

Comments

@Archelyst
Copy link

I have grids on a page that have width: 100%. When I then decrease the browser width, the grid content repeatedly jumps down for a moment before it jumps back. That looks really unclean and annoying. By adding an overflow-x: hidden to .ui-grid I was able to reduce that quite a bit. It's still there, but not as much and also it does not push down the content which is below the grid any more. Don't know if this has any negative side effects, though. None noticed so far.
@kelchm
Copy link

kelchm commented Mar 13, 2015

I've noticed this as well. Would be great to see ui-grid-auto-resize improved.

@c0bra c0bra self-assigned this Mar 13, 2015
@PaulL1 PaulL1 mentioned this issue Mar 28, 2015
Open
@c0bra
Copy link
Contributor

c0bra commented Apr 13, 2015

I haven't been able to find a solution that doesn't require altering how containers are rendered. It looks like we'll need to move away from floated elements and either absolutely position or use margins.

@c0bra c0bra added this to the 3.0 milestone Apr 13, 2015
@c0bra c0bra changed the title reduce flicker when resizing horizontically reduce flicker when resizing horizontally Apr 16, 2015
c0bra added a commit that referenced this issue Apr 27, 2015
@c0bra
fix(uiGrid): Use margins rather than floats for pinning
1373b99 
Pinned containers were wrapping in certain scenarios where grids were being resi
zed. It looked to the end-user like a poorly-rendered flash, and could possibly
happen over and over during resizing.

This fix uses margins to offset the body render container from the the left and
right render containers

Fixes #2997, Fixes #1957
@c0bra c0bra mentioned this issue Apr 27, 2015
Merged
@c0bra c0bra removed the in progress label Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c0bra c0bra

Labels
type: bug
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix grid reflow/wrapping issue angular-ui/ui-grid
3 participants
@c0bra @kelchm @Archelyst